feat(OpenAI): Add support for Remote MCP Tool #601
Conversation
|
Looks pretty close. Just a few lint warnings and I think good to go. |
trandbert37
force-pushed
the
feature/add-support-for-remote-mcp-tool
branch
from
672b8d9 to
a4142fa
Compare
There was a problem hiding this comment.
thanks for doing this! I've gotten busy so appreciate the help. You've helped me discover I missed streaming for image generation.
I put some comments on some mismatched variable types. I wonder if there is any sample hello world MCP servers that are accessible for real-life testing of this
|
I worked a bit on streaming today because it seemed Image Generation streaming was busted. I added that here: 0a29b39 and my real life sample test here - https://github.com/iBotPeaches/openai-php-laravel-test/blob/master/app/Console/Commands/ResponsesImageGenerationTest.php Sorry as that caused some conflicts here, but it should help overall as it boosted the streaming support for responses. |
# Conflicts: # src/Responses/Responses/CreateResponse.php # src/Responses/Responses/CreateStreamedResponse.php # src/Responses/Responses/RetrieveResponse.php # src/Responses/Responses/Streaming/OutputItem.php
…ai-php#602) * feat(OpenAI): Add streaming for ImageGeneration (Responses API) * fix(OpenAI): `model` is missing on stream and partial images is default 0 * test(OpenAI): image generation steaming test * fix(OpenAI): add output item (Image Generation) * fix(OpenAI): add output item (Image Generation) * test(OpenAI): enhanced stream testing * fix(OpenAI): image generation streaming fixes * fix(OpenAI): proper type * chore(OpenAI): align test to stream mock * fix(OpenAI): result is missing on partial image failure # Conflicts: # src/Responses/Responses/CreateResponse.php # src/Responses/Responses/CreateStreamedResponse.php # src/Responses/Responses/RetrieveResponse.php # src/Responses/Responses/Streaming/OutputItem.php
# Conflicts: # src/Responses/Responses/CreateResponse.php # src/Responses/Responses/CreateStreamedResponse.php # src/Responses/Responses/RetrieveResponse.php # src/Responses/Responses/Streaming/OutputItem.php
trandbert37
force-pushed
the
feature/add-support-for-remote-mcp-tool
branch
from
d7ab3ad to
28595da
Compare
|
Nice work! Appears to be passing CI and I'll run a real life test today at work and merge if so. |
iBotPeaches
changed the title
|
Ran some tests locally with real MCP and streaming and not - worked great! |
|
Perfect, thanks for the tests 🎉 |
|
thanks and congrats on 1st pr! |
What:
Description:
Add support for Remote MCP tool in Responses: https://platform.openai.com/docs/guides/tools-remote-mcp
Related:
fixes #583