This repository has been archived by the owner on May 5, 2022. It is now read-only.
Strip out any number of trailing zeros after the decimal point ".0+" #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… zeros after the decimal point
…0+ if the next letter is not a number
|
And again no running build, same deal as #656. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the new Belarus data set in openaddresses/openaddresses#3409, it would be useful for machine to strip multiple trailing zeros rather than only the single ".0" from the end of a float.
This PR will strip out the following pattern:
(?<=[0-9])\.0+(?![0-9]). Applies to join and format on any field and is used forrow_canonicalize_unit_and_number.The above regex will strip the
.0+in these cases:But not in these cases:
Added tests for the new functionality.