Skip to content
This repository has been archived by the owner on May 5, 2022. It is now read-only.

Add dynamic license API response #316

Merged
merged 5 commits into from
Mar 22, 2016
Merged

Add dynamic license API response #316

merged 5 commits into from
Mar 22, 2016

Conversation

migurski
Copy link
Member

Supports openaddresses/openaddresses-ops#11

Partial sample response:

{
  "licenses": [
    {
      "attribution": null, "license": null,
      "sources": [
        ["ca/bc/thompson-nicola-regional-district.json", "https://www.tnrd.ca/content/mapping-services-gis-overview"],
        ["ca/bc/vancouver.json", null]
      ]
    },
    {
      "attribution": "ACT Government, Australia", "license": null,
      "sources": [
        ["au/city_of_canberra.json", "http://www.actmapi.act.gov.au/html5.html"]
      ]
    },
    {
      "attribution": null, "license": "Polish Law on Geodesy and Cartography of 17 May 1989 (https://github.com/openaddresses/openaddresses/issues/187#issuecomment-63327973)",
      "sources": [
        ["pl/dolnoslaskie.json", null],
        ["pl/lodzkie.json", null]
      ]
    },
    {
      "attribution": null, "license": "Public Domain",
      "sources": [
        ["us/ca/san_francisco.json", "http://www.sfgov.org"],
        ["us/fl/manatee.json", "http://www.mymanatee.org/home/government/departments/information-technology/gis-home/gis-datadownload.html"]
      ]
    }
  ]
}

@migurski migurski changed the title Add dynamic license page Add dynamic license API response Mar 21, 2016
@iandees
Copy link
Member

iandees commented Mar 22, 2016

Hmm, the output of this feels "backwards" to me. Wouldn't consumers want to know the mapping between source and license info, not license info and source?

@NelsonMinar
Copy link
Contributor

I have the opposite feel from Ian, I like it being sorted by license category. Assuming there's only a few categories. Don't feel strongly though.

@riordan
Copy link

riordan commented Mar 22, 2016

There's reasons to go either way in terms of organization (or possibly both).

I just want to make sure that when it comes to generating an output from it (e.g. openaddresses/openaddresses.io#67), we display attribution segmented by license. That way users of the main collected.zip can point to a single place, while those that opt to add in the 2 share-alike sources can add the additional attribution link.

@migurski
Copy link
Member Author

My thinking about organization here is to bundle stuff like all the same-licensed Mexico or Poland sources together, so it’s clearer what the relationship is. OTOH, it would be possible to organize this any which way for output.

@iandees
Copy link
Member

iandees commented Mar 22, 2016 via email

@migurski
Copy link
Member Author

That’s over in this connected issue: openaddresses/openaddresses.io#67

@iandees
Copy link
Member

iandees commented Mar 22, 2016

Gotcha. I didn't see the screenshot on my phone earlier. I withdraw my concerns about the API format.

@migurski
Copy link
Member Author

👍 I’m going to deploy this. Thanks!

migurski added a commit that referenced this pull request Mar 22, 2016
@migurski migurski merged commit 5cfb0e7 into master Mar 22, 2016
@migurski migurski deleted the add-dynamic-license-page branch March 22, 2016 20:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants