Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validated S3 Links #271

Merged
merged 25 commits into from
Apr 7, 2022
Merged

Validated S3 Links #271

merged 25 commits into from
Apr 7, 2022

Conversation

ingalls
Copy link
Member

@ingalls ingalls commented Mar 2, 2022

Ref: #250

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #271 (927aef2) into master (e648304) will increase coverage by 0.35%.
The diff coverage is 46.42%.

❗ Current head 927aef2 differs from pull request most recent head d245a69. Consider uploading reports for the commit d245a69 to get more accurate results

@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
+ Coverage   57.74%   58.09%   +0.35%     
==========================================
  Files          47       47              
  Lines        2007     2019      +12     
==========================================
+ Hits         1159     1173      +14     
+ Misses        848      846       -2     
Impacted Files Coverage Δ
api/lib/run.js 63.28% <ø> (-0.29%) ⬇️
api/routes/fabric.js 35.00% <0.00%> (ø)
api/index.js 67.16% <36.36%> (-4.74%) ⬇️
api/lib/map.js 61.61% <41.17%> (+9.32%) ⬆️
api/routes/data.js 50.00% <50.00%> (ø)
api/routes/map.js 37.93% <50.00%> (+0.89%) ⬆️
api/lib/job.js 63.41% <100.00%> (+0.91%) ⬆️
api/routes/job.js 45.34% <100.00%> (+1.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e648304...d245a69. Read the comment docs.

@ingalls ingalls requested a deployment to prod March 2, 2022 14:06 Pending
@ingalls ingalls requested a deployment to prod March 28, 2022 13:17 Pending
@ingalls ingalls requested a deployment to prod March 28, 2022 15:50 Abandoned
@ingalls ingalls requested a deployment to prod March 28, 2022 19:42 Abandoned
@ingalls ingalls requested a deployment to prod April 7, 2022 16:48 Abandoned
@ingalls ingalls merged commit 566e7c3 into master Apr 7, 2022
@ingalls ingalls deleted the s3_validated branch April 7, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant