Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use polylabel for address point from polygon #12

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrewharvey
Copy link
Contributor

When an address source contains polygons, currently PointOnSurface is used to convert that into an address point. In this example below, the blue dots are centroids based on the polygons shown behind (importantly these are not the result of this batch code, as this example is from a point source).

While this is okay, a nicer location for the address point would be more where the background map shows it, closer to the pole of inaccessibility as created by polylabel.

2021-04-19_21-05

While there is no single correct location of where the point should be located, indeed different applications would want different locations like:

  • street frontage point
  • best position for labelling (polylabel)
  • best position for analysis (point on surface or centroid)

This PR is not complete (I haven't added shapely as a dependency, or done any testing yet, and I haven't yet looked at actual results from PointOnSurface and how it compares with Polylabel results for real world data) but shows in principle a potential change.

Not sure what kind of performance hit this would have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant