Migrate user home involvement to Boostrap #6397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ana06
added
Frontend
|
Review app will appear here: http://obs-reviewlab.opensuse.org/ana06-user_involvement |
saraycp
approved these changes
Nov 29, 2018
|
@Ana06, I'll add this screenshot to the comment to see easily the Search box before and after.
|
dmarcoux
reviewed
Nov 30, 2018
dmarcoux
suggested changes
Nov 30, 2018
Implement the involvement partial missing in the home page. As this page is finished now, enable it for all beta users.
by fixing the table layout. This is needed (or at least doesn't hurt) in all the dataTables.
There is bug in DataTable which makes the search input overflow in sm screens: mkhairi/jquery-datatables#14 Overwrite the CSS and remove the Search label until it is fixed. Co-authored-by: David Kang <[email protected]>
Fix broken tests after migrating user home page to Bootstrap. I changed/rename some html classes/id and remove some custom css that could be done with Bootstrap as well.
dmarcoux
approved these changes
Nov 30, 2018
bgeuken
approved these changes
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the involvement partial missing in the home page. As this page is finished now, enable it for all beta users.
I have also prevented text in dataTables to overflow by fixing the table layout. This is needed (or at least doesn't hurt) in all the dataTables:
Before
After
I have also fixed a bug in the search input from dataTable: mkhairi/jquery-datatables#14 This bug was really visible in the view, but it affects other views as well. The same fix could be reused.