-
Notifications
You must be signed in to change notification settings - Fork 618
resolved recently created clients fail to open issue #2321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
886ce38
to
6801c1e
Compare
The is the PR for "recently created clients fail to open" issue |
@@ -15,7 +15,7 @@ | |||
<application> | |||
<provider | |||
android:name="androidx.core.content.FileProvider" | |||
android:authorities="${applicationId}.provider" | |||
android:authorities="com.mifos.mifosxdroid.provider" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have configured multiple flavors in our app, such as demo and prod. If we define the package name statically, it will cause platform clashes, making it impossible to install both applications simultaneously.
And I don't think by changing this it does resolve the issue as indicated in the PR title.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That actually resolved the issue as there was no reference to application id upon clicking it
The error that was resolved was "Couldn't find meta-data for provider with authority com.mifos.mifosxdroid.provider"
Alright, I will try and focus on resolving the issue within the feature module without making changes to the manifest.
Thank you for your response
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sounds like we need to update the package name in the specific function or module where we're handling file-saving functionality. The issue might arise because the package name or cache directory we've defined doesn't match the current flavor or version of the installed app. To resolve this, we should ensure the package name and cache directory to aligns with the app's current configuration.
maybe the issue is in these files not in manifest -
Line 300 in 1bc8f49
val file = context.createTempImageFile() |
or here -
Line 932 in 1bc8f49
private fun Context.createTempImageFile(): File { |
private fun Context.createTempImageFile(): File {
val timeStamp = SimpleDateFormat("yyyyMMdd_HHmmss", Locale.getDefault()).format(Date())
val imageFileName = "JPEG_${timeStamp}_"
val storageDir = externalCacheDir ?: cacheDir
return File.createTempFile(
imageFileName,
".png",
storageDir
)
}
or updating file_provider or checking the path name might solve this issue here - https://github.com/openMF/android-client/blob/1bc8f49747d48550e515d30e75c373c93e5dfa49/feature/client/src/main/res/xml/feature_client_path_provider.xml
update with existing
<external-cache-path name="external_cache" path="." />
<cache-path name="internal_cache" path="." />
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I will look into that.
Thank you
@ufuomaisaac Hi, thank you for your efforts. We have completely moved our issue tracking to Jira. Please consider creating a ticket there, similar to how it's done on GitHub, and proceed with your work. You can find the link in the project's README. And join our daily standup for more development update if you haven't joined yet. |
There are no issues with the application configuration files, such as the manifest, ProGuard, R8, or project settings. All issues are related to the feature or core modules, so please focus on working with or modifying those files. Avoid making changes to the configuration files, as these are production apps. If any changes to these files inadvertently violate Play Store policies, we would need to fix them again, which could disrupt the release process. |
Fixes - Jira-#Issue_Number
recently creates clients fail to open issue was resolved