refactor: refactor NewIndividual Collection Sheet screen to jetpack compose with multi module #2100
Conversation
…ompose with multi module
|
|
| } | ||
|
|
||
| @Composable | ||
| fun MifosScaffoldNoTopBar( |
There was a problem hiding this comment.
Expose the Topbar in the above function and make it nullable and then update this function by passing null for topbar.
There was a problem hiding this comment.
I removed this composable and made the changes that you suggested.
There was a problem hiding this comment.
this should not be part of the source code, delete it and add in git ignore.
There was a problem hiding this comment.
Accidentally updated with code.
| @@ -9,4 +9,11 @@ android { | |||
|
|
|||
| dependencies { | |||
|
|
|||
| implementation(project(":core:datastore")) | |||
There was a problem hiding this comment.
have you tried projects.core.datastore, check it should be accessible
There was a problem hiding this comment.
I made this change
| @@ -18,27 +18,6 @@ import javax.inject.Singleton | |||
| @InstallIn(SingletonComponent::class) | |||
| class ApplicationModule { | |||
|
|
|||
| // @Provides | |||
There was a problem hiding this comment.
why did you commented this code?
There was a problem hiding this comment.
While implementing multi-module, I commented this code but forgot to remove it.
| ViewCompositionStrategy.DisposeOnViewTreeLifecycleDestroyed | ||
| ) | ||
| setContent { | ||
| val viewModel: NewIndividualCollectionSheetViewModel = hiltViewModel() |
There was a problem hiding this comment.
@PratyushSingh07 can you help @Aditya-gupta99 about injecting viewmodel in compose function
There was a problem hiding this comment.
I have asked him to make those changes
| @Composable | ||
| private fun NewIndividualCollectionSheetPreview() { | ||
| NewIndividualCollectionSheetScreen( | ||
| NewIndividualCollectionSheetUiState(), |
There was a problem hiding this comment.
In any way this will not generate the proper UI state wise preview, connect with @AvneetSingh2001 or @PratyushSingh07 fix this.
Fixes #2096
Jira MIFOSAC-202
XML Screen
Record_2024-05-14-23-57-10.mp4
Jetpack Compose
Record_2024-05-20-19-46-19.mp4
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.