Fixes #1559: Added internet connectivity check before loading client info #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danishjamal104
changed the title
iamsh4shank
requested changes
Nov 16, 2020
...-android/src/main/java/com/mifos/mifosxdroid/online/clientdetails/ClientDetailsFragment.java
Outdated
Show resolved
Hide resolved
danishjamal104
force-pushed
the
invalid-toast-in-client-info
branch
from
103a9b9
to
5ced72c
Compare
iamsh4shank
requested changes
Nov 16, 2020
...-android/src/main/java/com/mifos/mifosxdroid/online/clientdetails/ClientDetailsFragment.java
Outdated
Show resolved
Hide resolved
...-android/src/main/java/com/mifos/mifosxdroid/online/clientdetails/ClientDetailsFragment.java
Outdated
Show resolved
Hide resolved
danishjamal104
force-pushed
the
invalid-toast-in-client-info
branch
from
282d028
to
8a90109
Compare
danishjamal104
force-pushed
the
invalid-toast-in-client-info
branch
from
b9760b8
to
afcd23a
Compare
danishjamal104
force-pushed
the
invalid-toast-in-client-info
branch
from
afcd23a
to
f4b2be9
Compare
iamsh4shank
approved these changes
Jul 8, 2021
iamsh4shank
requested changes
Jul 20, 2021
There was a problem hiding this comment.
Hey @danishjamal104 can you fix the merge conflicts so that we could merge it soon :)
danishjamal104
force-pushed
the
invalid-toast-in-client-info
branch
from
f4b2be9
to
38081eb
Compare
therajanmaurya
requested changes
Feb 3, 2024
| @@ -174,7 +176,15 @@ class ClientDetailsFragment : MifosBaseFragment(), ClientDetailsMvpView { | |||
| } | |||
|
|
|||
| fun inflateClientInformation() { | |||
| mClientDetailsPresenter!!.loadClientDetailsAndClientAccounts(clientId) | |||
| val context = context | |||
There was a problem hiding this comment.
@danishjamal104 Move this in utils class, If Networkutils exist then fine otherwise create one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1559
Screenshot
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.