Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] download.go : Fail to gemix cluster install ... cause that grafana:7.5.17 's download url is changed #68

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Johnny-ZTSD
Copy link

…ana:7.5.17 's download url is changed. throw exception: "Error: receiving status of 404 for url: https://dl.grafana.com/oss/release/grafana-enterprise-7.5.17.linux-amd64.tar.gz" #67

#67

What problem does this PR solve?

Issue Number: close/fix/resolve/ref #xxx

What is changed and how it works?

fix the bug:
Fail to gemix cluster install ... cause that grafana:7.5.17 's download url is changed. throw exception: "Error: receiving status of 404 for url: https://dl.grafana.com/oss/release/grafana-enterprise-7.5.17.linux-amd64.tar.gz" #67

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B
  • Test cases to be added
  • [√] No code

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@@ -49,7 +49,13 @@ func Download(prefix, component, nodeOS, arch, version string) error {
arch = "amd64"
}
fileName = fmt.Sprintf("%s-enterprise-%s.%s-%s.tar.gz", component, ver.GrafanaVersion, nodeOS, arch)
componentUrl = strings.Join([]string{"https://dl.grafana.com/oss/release", fileName}, "/")
// FIX for : https://github.com/openGemini/gemix/issues/67
grafanaBaseUrlEnv := os.Getenv("GRAFANA_BASE_URL");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format your code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants