Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feeder cacheing #81

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Add feeder cacheing #81

merged 3 commits into from
Sep 12, 2024

Conversation

josephmckinsey
Copy link
Contributor

Solves #75

AadilLatif
AadilLatif previously approved these changes Jul 30, 2024
LocalFeeder/FeederSimulator.py Show resolved Hide resolved
@AadilLatif AadilLatif self-requested a review July 30, 2024 16:01
@AadilLatif AadilLatif dismissed their stale review July 30, 2024 16:01

tests not passing

@AadilLatif
Copy link
Collaborator

@josephmckinsey tests seem to be failing

FileNotFoundError: [Errno 2] Failed to open local file 'outputs_build/voltage_real.feather'. Detail: [errno 2] No such file or directory

@tarekelgindy tarekelgindy self-requested a review September 4, 2024 20:23
Copy link
Collaborator

@tarekelgindy tarekelgindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this now uses the default unit of seconds for the run. This works correctly without specifying the "s" at the end when it's run right?

@josephmckinsey
Copy link
Contributor Author

So this now uses the default unit of seconds for the run. This works correctly without specifying the "s" at the end when it's run right?

From the opendss manual:

You may specify the stepsize in seconds, minutes, or hours by appending ‘s’, ‘m’, or ‘h’ to the size value. If omitted, ‘s’ is assumed. Example: “set stepsize=15m” is the same as “set stepsize=900.” Do not leave a space between the value and the character

@josephmckinsey josephmckinsey merged commit 9362930 into main Sep 12, 2024
1 of 4 checks passed
@josephmckinsey josephmckinsey deleted the jm/existing_feeder_cache branch September 12, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants