Use multiplicative noise #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AadilLatif
reviewed
Mar 6, 2024
There was a problem hiding this comment.
@josephmckinsey unless I am mistaken, some json files need to be updated to comply with your new implementation
scenarios/large_aws_feeder.json
Outdated
| @@ -54,7 +60,7 @@ | |||
| "name": "sensor_voltage_magnitude", | |||
| "type": "MeasurementComponent", | |||
| "parameters": { | |||
| "gaussian_variance": 0.0, | |||
| "additive_noise_stddev": 0.0, | |||
| "random_percent": 0.0, | |||
There was a problem hiding this comment.
shouldn't this be "multiplicative_noise_stddev" instead?
scenarios/large_aws_feeder.json
Outdated
| @@ -63,7 +69,7 @@ | |||
| "name": "sensor_power_real", | |||
| "type": "MeasurementComponent", | |||
| "parameters": { | |||
| "gaussian_variance": 0.0, | |||
| "additive_noise_stddev": 0.0, | |||
| "random_percent": 0.0, | |||
There was a problem hiding this comment.
shouldn't this be "multiplicative_noise_stddev" instead?
| @@ -54,7 +60,7 @@ | |||
| "name": "sensor_voltage_magnitude", | |||
| "type": "MeasurementComponent", | |||
| "parameters": { | |||
| "gaussian_variance": 0.0, | |||
| "additive_noise_stddev": 0.0, | |||
| @@ -53,7 +59,7 @@ | |||
| "name": "sensor_voltage_magnitude", | |||
| "type": "MeasurementComponent", | |||
| "parameters": { | |||
| "gaussian_variance": 0.0, | |||
| "additive_noise_stddev": 0.0, | |||
| "random_percent": 0.0, | |||
josephmckinsey
force-pushed
the
jm/new_measuring
branch
from
2918a54
to
1bdd426
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes gaussian_variance and random_percent inputs.
Adds
Formula used is just$(1 + \epsilon_{mult}) X + \epsilon_{add}$ . Hopefully this is clear from the
transformfunction.