Add generic AWS SMART DS feeder #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The branch
update_types(#1 ) andaws_smartdshas revealed several problems such as #3. This pull request creates a new feederAWSFeederwhich downloads the feeder from AWS S3 when you first run the feeder. Note that this does not cache any results.As part of this, we discovered some discrepancies between the processed
LocalFeeder(previouslyBasicFeeder). This is separate from the permutation problem in #3.Finally, some minor plot improvements from
jm/better_plotswere included. Additionally, the MAPE and MAE do not count zero-voltage nodes (de-energized). We will likely have to change this slightly in the future so that we can compute the error in a proper way. It should be clear from the topology that the nodes should have zero voltage, so the error should still be counted in some way.