Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gadal integration #17

Merged
merged 31 commits into from
Sep 13, 2022
Merged

Gadal integration #17

merged 31 commits into from
Sep 13, 2022

Conversation

tarekelgindy
Copy link
Collaborator

Fully functional version of the gadal workflow with WLS algorithm.

@tareknrel
updating types send out by the feeder federates
6324b84
@tareknrel
updatingting types for recorder
56965e6
@tareknrel
removing ving labelled arrays
d0340ce
@tareknrel
incomplete update for measuring federate which uses input_mapping to …
6248dca 
…determine which federate it is. Need to update transform and wiring diagram
@tareknrel
updating wls component definition
7bfc382
@tareknrel
updating wiring diagram to have sensor for each type of measurement
496d56e
@tareknrel
componenet definition templates
054403f
@tareknrel
updating so that GADAL types are used. Seems to run ok.
888b1eb
@tareknrel
updating which gadal to use
cc20c4b
@tareknrel
updates to fix bug in wls algorithm with magnitudes and recorder sche…
2dbd9ff 
…ma to use time correctly
@tareknrel
deleting local feeder p1hs0_1247. For SMART-DS use AWS federate instead
d1a60be
@tareknrel
adding time to measureing federate
8a2c241
@tareknrel
updating to use timeseries info from opendss files directly
b3a45c9
@tareknrel
updating to use the ieee123 system
52a21cc
@tareknrel
include gadal-ieee123 repo as a submodule in LocalFeeder
14e263f
@tareknrel
updating local feeder to work with ieee123 bus system
fd4b5d0
@tareknrel
updating to work with IEEE123 bus system
0052f0b
@tareknrel
updating submoudule
ed099f0
@tareknrel
reducing number of steps
33aba56
@tareknrel
include submodule for gadal-ieee123 system
dac1786
@tareknrel
updating to try loading submodule with token
1dff0a6
@tareknrel
fixing location of token info
f665206
@tareknrel
updating post analysis script to work on local_feeder
441401d
josephmckinsey
josephmckinsey requested changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@josephmckinsey josephmckinsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things. Some of these could be future issues.

AWSFeeder/sender_cosim.py Show resolved Hide resolved
AWSFeeder/sender_cosim.py Outdated Show resolved Hide resolved
AWSFeeder/sender_cosim.py Show resolved Hide resolved
AWSFeeder/sender_cosim.py Outdated Show resolved Hide resolved
LocalFeeder/FeederSimulator.py Show resolved Hide resolved
wls_federate/state_estimator_federate.py Outdated Show resolved Hide resolved
wls_federate/state_estimator_federate.py Show resolved Hide resolved
wls_federate/state_estimator_federate.py Outdated Show resolved Hide resolved
wls_federate/state_estimator_federate.py Outdated Show resolved Hide resolved
wls_federate/state_estimator_federate.py Outdated Show resolved Hide resolved
josephmckinsey
josephmckinsey requested changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@josephmckinsey josephmckinsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can do better with git submodules.

.github/workflows/test-api.yml Show resolved Hide resolved
.gitmodules Outdated Show resolved Hide resolved
josephmckinsey
josephmckinsey approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@josephmckinsey josephmckinsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks ok. There's lots of little things we'll still need to change.

@tarekelgindy tarekelgindy mentioned this pull request Sep 13, 2022
Closed
@tarekelgindy tarekelgindy merged commit 0f7a53b into main Sep 13, 2022
@tarekelgindy tarekelgindy deleted the gadal_integration branch September 13, 2022 00:24
This was referenced Sep 16, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmckinsey josephmckinsey josephmckinsey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tarekelgindy @josephmckinsey @tareknrel