rpmsg_virtio: used list to handle the rx buffers #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch, if the recursive occur in the ept->cb() when we has get current rx buffer (1st buffer) and next rx buffer (2nd buffer), the 3rd rx buffer in the recursived ept->cb() will be handled ahead of the 2nd rx buffer. To avoid the out-of-order issue, use a list to store all the rx buffer, so the rx buffer will be hanlded strictly with the received order Signed-off-by: Bowen Wang <[email protected]> Signed-off-by: Yongrong Wang <[email protected]>
xiaoxiang781216
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Without this patch, if the recursive occur in the ept->cb() when we has get current rx buffer (1st buffer) and next rx buffer (2nd buffer), the 3rd rx buffer in the recursived ept->cb() will be handled ahead of the 2nd rx buffer.
To avoid the out-of-order issue, use a list to store all the rx buffer, so the rx buffer will be hanlded strictly with the received order
Impact
the rpmsg virtio communication
Testing
testing with sim rpproxy and rpserver config