LTP: fix linux testcases build error on vela #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
extinguish
commented
Dec 24, 2024
extinguish
commented
- tst_test.h: fix the kernel/tst_test.h "char **av" variable undeclared build error
- syscall/ipcsem: fix the function prototype declartion mismatch error
- asprintf: make the compilation of asprintf function controllable
- pipe02: fix the header file missing build error
- reiser_fract_tree.c: fix the long string print error
- add the missing header file
- syscall: remove the duplicate poll.h to fix link error
the "av[0]" variable are not declared inside pipe02.c, add "char **av"
inside tst_test.h to fix the build error
the detailed build error:
ltp/testcases/kernel/syscalls/pipe/pipe02.c:57:31: error: 'av' undeclared (first use in this function)
57 | if (self_exec(av[0], "dd", fd[0], fd[1]) < 0)
| ^~
Signed-off-by: guoshichao <[email protected]>
Signed-off-by: guoshichao <[email protected]>
the asprintf function implementation may be defined in some platform, for example, NuttX has provided the asprintf function already. so in order to build on other platform, we should make the compilation of asprintf controllable, just like other controllerable function, for example: HAVE_READLINKAT, HAVE_TIMERFD_CREATE .etc Signed-off-by: guoshichao <[email protected]>
add <sys/wait.h> header file to fix the link error Signed-off-by: guoshichao <[email protected]>
Signed-off-by: guoshichao <[email protected]>
Signed-off-by: guoshichao <[email protected]>
this `poll.h` file is located at `testcases/kernel/syscalls/utils`
directory. Since we need to export the `testcases/kernel/syscalls/utils`
path as the reference directory for header files, so when we use
`#include <poll.h>` anywhere in the entire system, it will give priority
to referencing the `testcases/kernel/syscalls/utils/poll.h` instead of
the `<poll.h>` in the current system. As a result, this will lead to
some compilation errors.
In addition, some of the contents defined in `testcases/kernel/syscalls/utils/poll.h`
also conflicts with those defined in the system's `<poll.h>`.
For example, the definition of `struct pollfd {}` is in conflict.
Therefore, we can't solve the error of duplicate definition of `struct pollfd {}`
just by using `#include_next <poll.h>` directly in `testcases/kernel/syscalls/utils/poll.h`.
Signed-off-by: guoshichao <[email protected]>
|
|
xiaoxiang781216
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.