Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] update content/ja/docs/concepts/sampling/index page #6333

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Msksgm
Copy link
Contributor

@Msksgm Msksgm commented Feb 15, 2025

I updated content/ja/docs/concepts/sampling/index page.
ref: #6172.

@opentelemetrybot opentelemetrybot requested review from a team February 15, 2025 00:50
@Msksgm Msksgm force-pushed the update-#6172/content/ja/docs/concepts/sampling/index branch 3 times, most recently from 63aed90 to acfadec Compare February 15, 2025 05:15
@Msksgm Msksgm marked this pull request as ready for review February 15, 2025 05:16
@Msksgm Msksgm requested a review from a team as a code owner February 15, 2025 05:16
Copy link
Contributor

@ymotongpoo ymotongpoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I left a comment for the translation of "when to".

加えて、多くのデータを生成するほど、代表的なサンプルを得るために必要なデータ量は実際には少なくなります。
高トラフィックのシステムでは、1 % 以下のサンプリング率でも残りの 99 % のデータを非常に正確に表現できることが一般的です。

### サンプルするとき {#when-to-sample}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

「疑問視 + to」は「〜すべきxx」という意味合いが強いのでここの2つの小見出しは「サンプリングすべきとき」「サンプリングすべきでないとき」が良いかと思います
https://www.rarejob.com/englishlab/column/20230619/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ymotongpoo

Thank you for your review.
I fixed it in a bellow commit.

a52d9fb

@ymotongpoo ymotongpoo force-pushed the update-#6172/content/ja/docs/concepts/sampling/index branch from acfadec to 09c4ecc Compare February 19, 2025 06:37
@opentelemetrybot opentelemetrybot requested a review from a team February 19, 2025 06:37
@opentelemetrybot opentelemetrybot requested review from a team and mx-psi and removed request for a team February 19, 2025 21:21
@Msksgm Msksgm force-pushed the update-#6172/content/ja/docs/concepts/sampling/index branch from b478ca3 to a52d9fb Compare February 19, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants