-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✅ [outreachy] fix: adjust styles to fix a11y issues #5481
base: main
Are you sure you want to change the base?
✅ [outreachy] fix: adjust styles to fix a11y issues #5481
Conversation
Can you run the reporting tool against the preview site and verify that the issues have been resolved? |
It's all clear for 2AA except for the code blocks pa11y https://deploy-preview-5481--opentelemetry.netlify.app/ecosystem/registry/ Welcome to Pa11y
Results for URL: https://deploy-preview-5481--opentelemetry.netlify.app/ecosystem/registry/ • Error: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 3.32:1. Recommendation: change text colour to #3f8100. • Error: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 3.32:1. Recommendation: change text colour to #3f8100. • Error: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 3.32:1. Recommendation: change text colour to #3f8100. • Error: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 3.32:1. Recommendation: change text colour to #3f8100. • Error: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 3.32:1. Recommendation: change text colour to #3f8100. • Error: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 3.32:1. Recommendation: change text colour to #3f8100. 6 Errors |
I consider this as done! After the outreachy application phase we will take another look and see if we can merge this PR. Thank you! if you want to clean the CI check issues run |
This PR Fixes #5371
It focuses on color contrast between buttons and links. And aims to solve these issues - https://gist.github.com/FatumaA/3141068e904cbcf4e2c53936f42d3d62