Add support for Default Baggage Injection in URLSessionInstrumentation #639
+105
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batuhansk
requested review from
nachoBonafonte,
bryce-b and
vvydier
as code owners
batuhansk
changed the title
nachoBonafonte
requested changes
Nov 21, 2024
Tests/InstrumentationTests/URLSessionTests/URLSessionInstrumentationTests.swift
Show resolved
Hide resolved
nachoBonafonte
approved these changes
Nov 21, 2024
vvydier
approved these changes
Nov 21, 2024
…trumentationconfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces a
defaultBaggageProvidercallback inURLSessionInstrumentationConfiguration, enabling a default baggage to be applied globally to all instrumented requests. The provided baggage is combined with active baggage when available, or used standalone otherwise. ThetracePropagationHTTPHeadersmethod has been optimized to ensure clear and concise baggage propagation across all requests.