-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update LogRecord batching processor behavior description #4409
Open
JDUNNIN
wants to merge
11
commits into
open-telemetry:main
Choose a base branch
from
JDUNNIN:issue-4402
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+23
−1
Open
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
bb2add8
Add more description to OTEL_BSP_SCHEDULE_DELAY and OTEL_BLRP_SCHEDUL…
JDUNNIN 0b10e27
Correct name of property
JDUNNIN fe114f8
Add reference to Batching processor for Trace and Logs + make Logs de…
JDUNNIN dea0d32
Merge branch 'main' into issue-4402
JDUNNIN 3fc4784
Change to relative hyperlink + remove full stops added by mistake (ad…
JDUNNIN 86aaf01
Merge branch 'issue-4402' of github.com:JDUNNIN/opentelemetry-specifi…
JDUNNIN eb7868f
Add equivallent description from Trace to Logs batch
JDUNNIN 73500cb
Merge branch 'main' into issue-4402
pellared 8c22ecc
Add shutdown detail
JDUNNIN 63df65c
Merge branch 'issue-4402' of github.com:JDUNNIN/opentelemetry-specifi…
JDUNNIN 3173b33
Fix relative links by adding .md
JDUNNIN File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -421,6 +421,20 @@ representations to the configured `LogRecordExporter`. | |
The processor MUST synchronize calls to `LogRecordExporter`'s `Export` | ||
to make sure that they are not invoked concurrently. | ||
|
||
The processor SHOULD export a batch when any of the following happens AND the | ||
previous export call has returned: | ||
|
||
- `scheduledDelayMillis` after the processor is constructed OR the first `LogRecord` | ||
is received by the log record processor. | ||
Comment on lines
+427
to
+428
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why would we want to have the 2nd part? Asking this question more coming from "why do we want to have complex rules instead of simple rules".
|
||
- `scheduledDelayMillis` after the previous export timer ends, OR the previous | ||
export completes, OR the first `LogRecord` is added to the queue after the previous | ||
export timer ends or previous batch completes. | ||
- The queue contains `maxExportBatchSize` or more `LogRecord`s. | ||
- `ForceFlush` is called. | ||
JDUNNIN marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
If the queue is empty when an export is triggered, the processor MAY export | ||
an empty batch OR skip the export and consider it to be completed immediately. | ||
|
||
**Configurable parameters:** | ||
|
||
* `exporter` - the exporter where the `LogRecord`s are pushed. | ||
|
@@ -431,7 +445,9 @@ to make sure that they are not invoked concurrently. | |
* `exportTimeoutMillis` - how long the export can run before it is cancelled. | ||
The default value is `30000`. | ||
* `maxExportBatchSize` - the maximum batch size of every export. It must be | ||
smaller or equal to `maxQueueSize`. The default value is `512`. | ||
smaller or equal to `maxQueueSize`. If the queue reaches `maxExportBatchSize` | ||
a batch will be exported even if `scheduledDelayMillis` milliseconds have not | ||
elapsed. The default value is `512`. | ||
pellared marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
## LogRecordExporter | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why export when first record is received 🤔 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the original author meant "delay after first record'. Probably this could be clarified, but I do not feel it has to be done in this PR.