fix(proto): Permissive integers in protobuf JSON parsing #3329
+90
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3328
Changes
Ensure that we accept both
u64andStringas inputs for large numbers, as the protobuf spec dictates (see #3328).Note: This deviates in pattern slightly from established code, using a visitor for
IntOrString-- I hope this is okay, but there's potential to unify here.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes(Technically it is an API change, since more values are now accepted?)