Skip to content

Conversation

@marc-pydantic
Copy link

@marc-pydantic marc-pydantic commented Jan 26, 2026

Fixes: #3328

Changes

Ensure that we accept both u64 and String as inputs for large numbers, as the protobuf spec dictates (see #3328).

Note: This deviates in pattern slightly from established code, using a visitor for IntOrString -- I hope this is okay, but there's potential to unify here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

(Technically it is an API change, since more values are now accepted?)

@marc-pydantic marc-pydantic requested a review from a team as a code owner January 26, 2026 17:07
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 26, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: marc-pydantic / name: Marc Brinkmann (c1587f5)

@marc-pydantic marc-pydantic changed the title Permissive integers in protobuf JSON parsing fix: Permissive integers in protobuf JSON parsing Jan 26, 2026
@marc-pydantic marc-pydantic changed the title fix: Permissive integers in protobuf JSON parsing fix(proto): Permissive integers in protobuf JSON parsing Jan 26, 2026
@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.3%. Comparing base (580633e) to head (c1587f5).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3329   +/-   ##
=====================================
  Coverage   81.3%   81.3%           
=====================================
  Files        128     128           
  Lines      23641   23641           
=====================================
+ Hits       19228   19232    +4     
+ Misses      4413    4409    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marc-pydantic
Copy link
Author

Had some issue with the CLA system, but these are resolved now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: timestamps encoded as u64 are not accepted (JSON)

1 participant