chore: Unify SpanExporter with LogExporter and PushMetricExporter
#3281
+43
−38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2262
Changes
Changes
SpanExportertrait methods from&mut selfto&self:shutdown(&self)shutdown_with_timeout(&self, timeout)force_flush(&self)Also fixes
shutdown()default timeout from 5 nanoseconds to 5 seconds to make it consistent with the others (assume this was a typo!).Refactors
TonicTracesClientto wrapinnerinMutex<Option<...>>for interior mutability, aligning its structureand export pattern with
TonicLogsClientandTonicMetricsClient.This is breaking change - Implementers of
SpanExportermust update method signatures. Those already using interior mutability are good.