Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add criterion to workspace dependencies #1883

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Jun 13, 2024

Changes

  • criterion is used by multiple projects
  • Add criterion to workspace dependencies
  • Use the package version specified in workspace dependencies for criterion and a few other packages

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.6%. Comparing base (66e3ea5) to head (b6ef166).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1883     +/-   ##
=======================================
- Coverage   74.6%   74.6%   -0.1%     
=======================================
  Files        122     122             
  Lines      19952   19952             
=======================================
- Hits       14902   14901      -1     
- Misses      5050    5051      +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@utpilla utpilla marked this pull request as ready for review June 13, 2024 22:06
@utpilla utpilla requested a review from a team as a code owner June 13, 2024 22:06
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cijothomas cijothomas merged commit 50c574a into open-telemetry:main Jun 14, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants