Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix otlp/json exporter #1882

Merged
merged 9 commits into from
Jun 18, 2024
Merged

fix otlp/json exporter #1882

merged 9 commits into from
Jun 18, 2024

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Jun 13, 2024

#1763

Changes

As discussed here, the unit-test are contributed by @hwrdtm

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team as a code owner June 13, 2024 21:40
@lalitb
Copy link
Member Author

lalitb commented Jun 13, 2024

Moving to draft to add changelog and enable integration test.

@lalitb lalitb marked this pull request as draft June 13, 2024 21:41
@lalitb lalitb changed the title Fix OTLP Http JSON exporter Fix otlp/json exporter Jun 13, 2024
@lalitb lalitb changed the title Fix otlp/json exporter fix otlp/json exporter Jun 13, 2024
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.6%. Comparing base (da368d4) to head (5f93ef3).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1882     +/-   ##
=======================================
- Coverage   74.6%   74.6%   -0.1%     
=======================================
  Files        122     122             
  Lines      19952   19952             
=======================================
- Hits       14902   14901      -1     
- Misses      5050    5051      +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb
Copy link
Member Author

lalitb commented Jun 14, 2024

Moving to draft to add changelog and enable integration test.

ok, I will create a separate PR for adding this to the integration test, it's a slightly bigger effort. We already have the unit test to validate the fix. Also added the changelog.

@lalitb lalitb marked this pull request as ready for review June 14, 2024 20:22
@lalitb
Copy link
Member Author

lalitb commented Jun 18, 2024

merging, will incorporate any new comments in a separate PR.

@lalitb lalitb merged commit e0fb7fe into open-telemetry:main Jun 18, 2024
24 checks passed
This was referenced Jun 18, 2024
ramgdev pushed a commit to ramgdev/opentelemetry-rust that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants