Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group Logs and Spans by Resource and Instrumentation Scope in OTLP Exporter #1873

Merged
merged 21 commits into from
Jun 26, 2024

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Jun 10, 2024

Changes

Refactor the log and span batching mechanism in the OTLP exporters to combine logs with the same resource and instrumentation scope before export.

Input:
(res1, lib1, log1), (res1, lib1, log2), (res1, lib2, log3), (res1, lib1, log4)

Output:
(res1, (lib1, (log1, log2, log4)), (lib2, (log3)))

The main changes include:
Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team as a code owner June 10, 2024 20:55
@lalitb lalitb changed the title Group Logs by Resource and Instrumentation Scope in OTLP Exporter before export Group logs and spans by Resource and Instrumentation Scope in OTLP Exporter before export Jun 10, 2024
@lalitb lalitb marked this pull request as draft June 10, 2024 20:56
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 95.14563% with 15 lines in your changes missing coverage. Please review.

Project coverage is 75.0%. Comparing base (b3315f2) to head (242d8ff).

Files Patch % Lines
opentelemetry-otlp/src/exporter/tonic/logs.rs 0.0% 7 Missing ⚠️
opentelemetry-otlp/src/exporter/http/mod.rs 0.0% 3 Missing ⚠️
opentelemetry-proto/src/transform/trace.rs 98.4% 3 Missing ⚠️
opentelemetry-otlp/src/exporter/http/logs.rs 0.0% 1 Missing ⚠️
opentelemetry-otlp/src/exporter/http/trace.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1873     +/-   ##
=======================================
+ Coverage   74.6%   75.0%   +0.3%     
=======================================
  Files        122     122             
  Lines      20001   20279    +278     
=======================================
+ Hits       14933   15212    +279     
+ Misses      5068    5067      -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb lalitb changed the title Group logs and spans by Resource and Instrumentation Scope in OTLP Exporter before export Group Logs and Spans by Resource and Instrumentation Scope in OTLP Exporter Jun 11, 2024
@lalitb lalitb added the integration tests Run integration tests label Jun 12, 2024
@lalitb lalitb marked this pull request as ready for review June 12, 2024 00:41
@ramgdev
Copy link
Contributor

ramgdev commented Jun 12, 2024

Looks good. Thanks for covering both logs and traces!

@cijothomas cijothomas merged commit 9b746e0 into open-telemetry:main Jun 26, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration tests Run integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants