Upgrade to hyper/http v1.0

[aumetra]

Fixes #1427

Blocked by:

• Upgrade to Hyper 1.0 & Axum 0.7 hyperium/tonic#1670
• Enable diagnostic attributes for Rust 1.78+ tokio-rs/axum#2693

Changes

• Update all hyper and http dependencies to v1.x
• Update reqwest to v0.12
• Remove isahc since it's still stuck on http v0.2

Merge requirement checklist

• CONTRIBUTING guidelines followed
• Unit tests added/updated (if applicable)
• Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
• Changes in public API reviewed (if applicable)

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: aumetra / name: Aumetra Weisman (c93e43f, 25f9213, 1a3d711, e22bb0b, f5c73eb, 75b3259, 7d1c3a1, 95608c5, 318bb62, 88ad416, 19ddbd8, 8ad764a, 6f34ee3, 40fa576, adda11d, 70a9bc7, a87360b, 6c75e7c, 45903d8, e52ba2c, af97e0e, eb2ae32, 650e688, 8e6c5d2, 0664b64, 23c09c7, 5944e90, 1678306, 832b1cb, c840978, 1d1cef9, ab7a3a4)
• ✅ login: lalitb / name: Lalit Kumar Bhasin (7d9670f)

[aumetra]

Lint needs to have a feature enabled that's transitively enabled if the full workspace is checked, will do that later.
The external types check is broken because the nightly used is too old and axum unconditionally enables the diagnostic attribute on nightly without the feature flag because they assume everyone is at least on a nightly that is 1.68

[mladedav]

I have a few minor points. Feel free to ignore it if you don't care about the features as this should never break anyone unless a downstream crate or cargo make breaking changes and at that point all bets are off.

I think this could also be merged without waiting on tonic by adding a dependency on [email protected] to opentelemetry-otlp and using that for tonic-specific errors since that's the only place where these types figure as far as I could find.

[aumetra]

Sidenote: The some tests in this repository seem flakey? Locally I sometimes have to rerun the tests a few times before they pass. Weird.

[TommyCpp]

The some tests in this repository seem flakey

Yeah feel free to report those test in #1559. Most of them are because global setup / env vars and we are working on addressing them as they pop up

[codecov]

Codecov Report

Attention: Patch coverage is 10.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 75.0%. Comparing base (df815bd) to head (7d9670f).
Report is 1 commits behind head on main.

Files	Patch %	Lines
opentelemetry-http/src/lib.rs	0.0%	18 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##            main   #1674     +/-   ##
=======================================
- Coverage   75.0%   75.0%   -0.1%     
=======================================
  Files        122     122             
  Lines      20276   20290     +14     
=======================================
  Hits       15222   15222             
- Misses      5054    5068     +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[aumetra]

(missed that one during the last rebase)

[NOBLES5E]

I was wondering if this is planned to be merged anytime soon?

[aumetra]

I was wondering if this is planned to be merged anytime soon?

I'm intending to get this over the finish line eventually, issue is just that the tonic PR is still pending

[lalitb]

@aumetra The tonic PR is merged. do you think we can now remove the patch from this PR, and make it ready to review/merge.

Edit - Or probably better to wait for tonic release with merged changes.

[aumetra]

As soon as it's released, sure!

[aumetra]

Seems like tonic is close to releasing v0.12 with hyper v1 support.
After they publish it, I'll rebase and remove the patches

hyperium/tonic#1740

[djc]

(Drive-by feedback:)

This is looking pretty good, looking forward to getting this released! Have some nits for your consideration.

[aumetra]

@aumetra Is the upgrade to opentelemetry-proto submodule intended/required? If not, can we remove it from this PR, to be handled separately.

Not intended. Probably mistyped somewhere when attempting to reset the git submodule. Gonna revert that

[lalitb]

LGTM. Thanks for the work @aumetra. Will keep this open for another day to give other approvers a chance to review before merging.

[djc]

@lalitb are you planning a release? Need help with that?

[lalitb]

@lalitb are you planning a release? Need help with that?

@djc yes I believe @cijothomas plans to do a release today if there are no issues.

[djc]

Great, looking forward to it!