fix review comment

open-telemetry · Jun 18, 2024 · c61cc57 · c61cc57
1 parent 3c933ad
commit c61cc57
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/opentelemetry-appender-tracing/src/layer.rs b/opentelemetry-appender-tracing/src/layer.rs
@@ -172,7 +172,7 @@ where
  let mut log_record = self.logger.create_log_record();
  log_record.set_severity_number(severity_of_level(meta.level()));
  log_record.set_severity_text(meta.level().to_string().into());
- log_record.set_target(meta.target().to_string());
+ log_record.set_target(meta.target());
 
  let mut visitor = EventVisitor::new(&mut log_record);
  visitor.visit_metadata(meta);

diff --git a/opentelemetry-proto/src/transform/common.rs b/opentelemetry-proto/src/transform/common.rs
@@ -57,6 +57,7 @@ pub mod tonic {
  let (library, target) = data;
  InstrumentationScope {
  name: target
+ .map(|t| t.to_string())
  .unwrap_or_else(|| library.name.into_owned()),
  version: library.version.map(Cow::into_owned).unwrap_or_default(),
  attributes: Attributes::from(library.attributes).0,
@@ -80,7 +81,7 @@ pub mod tonic {
  let (library, target) = data;
  InstrumentationScope {
  name: target
- .map(|t| t.replace("::", "."))
+ .map(|t| t.to_string())
  .unwrap_or_else(|| library.name.to_string()),
  version: library
  .version