review comments

open-telemetry · Jun 11, 2024 · 894dd71 · 894dd71
1 parent abade5c
commit 894dd71
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 6 deletions.
diff --git a/examples/self-diagnostics/Cargo.toml b/examples/self-diagnostics/Cargo.toml
@@ -11,7 +11,6 @@ opentelemetry_sdk = { path = "../../opentelemetry-sdk", features = ["rt-tokio"]}
 opentelemetry-stdout = { path = "../../opentelemetry-stdout"}
 opentelemetry-appender-tracing = { path = "../../opentelemetry-appender-tracing"}
 tokio = { workspace = true, features = ["full"] }
-serde_json = { workspace = true }
 tracing = { workspace = true, features = ["std"]}
 tracing-core = { workspace = true }
 tracing-subscriber = { version = "0.3.18", features = ["env-filter","registry", "std"]}

diff --git a/examples/self-diagnostics/docker-compose.yaml b/examples/self-diagnostics/docker-compose.yaml
@@ -9,7 +9,3 @@ services:
       - ./otel-collector-config.yaml:/etc/otel-collector-config.yaml
     ports:
       - "4318:4318"   # OTLP HTTP receiver
-
-
-
-
diff --git a/examples/self-diagnostics/src/main.rs b/examples/self-diagnostics/src/main.rs
@@ -116,7 +116,7 @@ async fn main() -> Result<(), Box<dyn Error + Send + Sync + 'static>> {
     let counter = meter.u64_counter("my_counter").init();
 
     // Record measurements with unique key-value pairs to exceed the cardinality limit
-    // and trigger error message
+    // of 2000 and trigger error message
     for i in 0..3000 {
         counter.add(
             10,