ValueMap interface change

open-telemetry · Sep 18, 2024 · 6968110 · 6968110
1 parent 3976f3d
commit 6968110
Show file tree

Hide file tree

Showing 7 changed files with 306 additions and 221 deletions.
diff --git a/opentelemetry-sdk/src/metrics/internal/exponential_histogram.rs b/opentelemetry-sdk/src/metrics/internal/exponential_histogram.rs
@@ -343,6 +343,7 @@ impl<T: Number> ExpoHistogram<T> {
     pub(crate) fn measure(&self, value: T, attrs: &[KeyValue]) {
         let f_value = value.into_float();
         // Ignore NaN and infinity.
+        // Only makes sense if T is f64, maybe this could be no-op for other cases?
         if f_value.is_infinite() || f_value.is_nan() {
             return;
         }