feat: sem_conv stability mode #1728
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahramadan
changed the title
semantic_conventions/lib/opentelemetry/semantic_conventions/stability_mode.rb
Outdated
Show resolved
Hide resolved
semantic_conventions/lib/opentelemetry/semantic_conventions/stability_mode.rb
Outdated
Show resolved
Hide resolved
semantic_conventions/lib/opentelemetry/semantic_conventions/stability_mode.rb
Outdated
Show resolved
Hide resolved
semantic_conventions/lib/opentelemetry/semantic_conventions/stability_mode.rb
Outdated
Show resolved
Hide resolved
semantic_conventions/lib/opentelemetry/semantic_conventions/stability_mode.rb
Show resolved
Hide resolved
semantic_conventions/lib/opentelemetry/semantic_conventions/stability_mode.rb
Outdated
Show resolved
Hide resolved
Co-authored-by: Kayla Reopelle <[email protected]>
hannahramadan
changed the title
hannahramadan
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam and
robbkidd
as code owners
|
Link to instrumentation that uses this PR: open-telemetry/opentelemetry-ruby-contrib#1166 |
kaylareopelle
added
the
spec-compliance
kaylareopelle
requested changes
Oct 2, 2024
| HTTP_DUP = 'http/dup' | ||
|
|
||
| # These constants will be pulled in from elsehwere once semvconv stability PR merged | ||
| # https://github.com/open-telemetry/opentelemetry-ruby/pull/1651 |
There was a problem hiding this comment.
It looks like there's a few stable attributes that aren't included in this PR. Why did you choose to use these attributes and not others?
https://opentelemetry.io/docs/specs/semconv/http/http-spans/#http-client
| @lock.synchronize do | ||
| opt_in = ENV.fetch('OTEL_SEMCONV_STABILITY_OPT_IN', nil) | ||
| opt_in_list = opt_in.split(',').map(&:strip) if opt_in | ||
| http_set_sability_mode(opt_in_list) if opt_in_list |
There was a problem hiding this comment.
Suggested change
| http_set_sability_mode(opt_in_list) if opt_in_list | |
| http_set_stability_mode(opt_in_list) if opt_in_list |
| end | ||
| end | ||
|
|
||
| def http_set_sability_mode(opt_in_list) |
There was a problem hiding this comment.
Suggested change
| def http_set_sability_mode(opt_in_list) | |
| def http_set_stability_mode(opt_in_list) |
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lays the foundation for accepting a new environment variable,
OTEL_SEMCONV_STABILITY_OPT_IN, which gives users the ability to determine which semantic conventions to use. Individual instrumentation are expected to add metrics/attributes by calling the methods present inOpenTelemetry::SemanticConventions::StabilityMode. This borrows from Pythons implementation.Only HTTP is supported for now (spec) and the values defined so far are:
http- emit the new, stable HTTP and networking conventions onlyhttp/dup- emit both the old and the stable HTTP and networking conventionsdefault- continue emitting whatever version of the old experimental HTTP and networking conventions the instrumentation was emitting previously.http/duphas higher precedence thanhttpin case both values are present