Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🚧 WIP: Logger instrumentation #983

Draft
wants to merge 58 commits into
base: main
Choose a base branch
from
Draft

feat: 🚧 WIP: Logger instrumentation #983

wants to merge 58 commits into from

Commits on Sep 19, 2023

  1. WIP initial commit logger instrumentation

    @kaylareopelle
    kaylareopelle committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    ec2c192 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Rubocop require_relative

    @kaylareopelle
    kaylareopelle committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    f4add62 View commit details
    Browse the repository at this point in the history

  2. Add :: to find Ruby logger instead of OTel logger

    @kaylareopelle
    kaylareopelle committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    456d25b View commit details
    Browse the repository at this point in the history

  3. Remove commented out option LOC

    @kaylareopelle
    kaylareopelle committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    e39763a View commit details
    Browse the repository at this point in the history

  4. Add skip_instrumenting? method

    @kaylareopelle
    kaylareopelle committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    976f329 View commit details
    Browse the repository at this point in the history

  5. Skip ActiveSupport::Logger#broadcast loggers

    @kaylareopelle
    kaylareopelle committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    ffd3fc5 View commit details
    Browse the repository at this point in the history

  6. Add logger instrumentation library and version

    @kaylareopelle
    kaylareopelle committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    bf2f998 View commit details
    Browse the repository at this point in the history

  7. Update severity_number logic, return orig value

    @kaylareopelle
    kaylareopelle committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    2df26a6 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. Make instrumentation name a constant

    @kaylareopelle
    kaylareopelle committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    b0ab18f View commit details
    Browse the repository at this point in the history

  2. WIP test active support logger

    @kaylareopelle
    kaylareopelle committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    595ecc5 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. Merge branch 'main' into logger-instrumentation

    @kaylareopelle
    kaylareopelle authored Mar 29, 2024
    Configuration menu
    Copy the full SHA
    cf920dd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/kaylareopelle/opentelemetry… 

    …-ruby-contrib into logger-instrumentation
    @khushijain21
    khushijain21 committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    f510b3d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'logger-instrumentation' of https://github.com/kaylareop… 

    …elle/opentelemetry-ruby-contrib into logger-instrumentation
    @khushijain21
    khushijain21 committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    90c6820 View commit details
    Browse the repository at this point in the history

  4. Map logger level to OTel level

    @khushijain21
    khushijain21 committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    58c82a7 View commit details
    Browse the repository at this point in the history

  5. Install WIP logs dependencies from git, not local

    @kaylareopelle
    kaylareopelle committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    c587212 View commit details
    Browse the repository at this point in the history

  6. Update rubocop dependencies

    @kaylareopelle
    kaylareopelle committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    a4e980d View commit details
    Browse the repository at this point in the history

  7. Disable active_support_logger tests 

    Appraisal can't install gems from a git source.
Since the appraisal is only necessary for active_support_logger,
disable those tests while working on other features.
    @kaylareopelle
    kaylareopelle committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    4604a96 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2024

  1. Merge pull request #1 from kaylareopelle/disable-rails-testing 

    chore: Allow logger patch tests to run
    @khushijain21
    khushijain21 authored Mar 30, 2024
    Configuration menu
    Copy the full SHA
    f995baa View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Merge branch 'main' of https://github.com/kaylareopelle/opentelemetry… 

    …-ruby-contrib into logger-instrumentation
    @khushijain21
    khushijain21 committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    6e96fcd View commit details
    Browse the repository at this point in the history

  2. maps otel log level

    @khushijain21
    khushijain21 committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    b8ae0d9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into logger-instrumentation

    @kaylareopelle
    kaylareopelle committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    9bac90d View commit details
    Browse the repository at this point in the history

  4. Merge branch 'logger-instrumentation' of https://github.com/kaylareop… 

    …elle/opentelemetry-ruby-contrib into logger-instrumentation
    @khushijain21
    khushijain21 committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    595e7aa View commit details
    Browse the repository at this point in the history

  5. Merge pull request #2 from khushijain21/logger-instrumentation 

    feat: map logger level to OTel level
    @kaylareopelle
    kaylareopelle authored Apr 4, 2024
    Configuration menu
    Copy the full SHA
    33f81f6 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Use the updated method name to emit, on_emit

    @kaylareopelle
    kaylareopelle committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    97ea4c9 View commit details
    Browse the repository at this point in the history

  2. Update tests referencing severity numbers

    @kaylareopelle
    kaylareopelle committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    f7646f8 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Merge branch 'main' into logger-instrumentation

    @kaylareopelle
    kaylareopelle committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    d838da7 View commit details
    Browse the repository at this point in the history

  2. Loosen dependency version restrictions

    @kaylareopelle
    kaylareopelle committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    483343c View commit details
    Browse the repository at this point in the history

  3. fix: Remove NAME constant from gemspec

    @kaylareopelle
    kaylareopelle committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    c35df18 View commit details
    Browse the repository at this point in the history

  4. chore: Address Rubocop require_relative linter

    @kaylareopelle
    kaylareopelle committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    686f2d9 View commit details
    Browse the repository at this point in the history

  5. Rubocop

    @kaylareopelle
    kaylareopelle committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    1bd3ead View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. fix: Bring back the NAME constant 

    It's used in the instrumentation when on_emit is called
    @kaylareopelle
    kaylareopelle committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    8b06c93 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Merge branch 'main' into logger-instrumentation

    @kaylareopelle
    kaylareopelle committed May 10, 2024
    Configuration menu
    Copy the full SHA
    747f3cd View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. chore: Correct version number, add TODOs in README

    @kaylareopelle
    kaylareopelle committed May 14, 2024
    Configuration menu
    Copy the full SHA
    66d3b3f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into logger-instrumentation

    @kaylareopelle
    kaylareopelle authored May 14, 2024
    Configuration menu
    Copy the full SHA
    2358235 View commit details
    Browse the repository at this point in the history

  3. fix: Revert version for now

    @kaylareopelle
    kaylareopelle committed May 14, 2024
    Configuration menu
    Copy the full SHA
    4c6d6f1 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. change

    @khushijain21
    khushijain21 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    0527726 View commit details
    Browse the repository at this point in the history

  2. move options

    @khushijain21
    khushijain21 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    7dfba21 View commit details
    Browse the repository at this point in the history

  3. accomodated changes

    @khushijain21
    khushijain21 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    03868bc View commit details
    Browse the repository at this point in the history

  4. removed configuring logger_provider

    @khushijain21
    khushijain21 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    c96243b View commit details
    Browse the repository at this point in the history

  5. removed corresponding test

    @khushijain21
    khushijain21 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    2c9a3e3 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #5 from khushijain21/rubybridge2 

    feat: methods to set custom logger name and version
    @kaylareopelle
    kaylareopelle authored May 15, 2024
    Configuration menu
    Copy the full SHA
    fb0b5c8 View commit details
    Browse the repository at this point in the history

  7. chore: Add tests for name and version config

    @kaylareopelle
    kaylareopelle committed May 15, 2024
    Configuration menu
    Copy the full SHA
    236bf1f View commit details
    Browse the repository at this point in the history

  8. Merge pull request #6 from kaylareopelle/config-tests 

    chore: Add tests for name and version config
    @kaylareopelle
    kaylareopelle authored May 15, 2024
    Configuration menu
    Copy the full SHA
    e3162e0 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. chore: Rubocop

    @kaylareopelle
    kaylareopelle committed May 16, 2024
    Configuration menu
    Copy the full SHA
    b0b301f View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. add check for logs sdk

    @khushijain21
    khushijain21 committed May 17, 2024
    Configuration menu
    Copy the full SHA
    e6799ff View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Merge pull request #7 from khushijain21/rubybridge2 

    feat: add check for logs sdk
    @kaylareopelle
    kaylareopelle authored May 21, 2024
    Configuration menu
    Copy the full SHA
    b0da0f1 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. test: Reinstate active support logger tests

    @kaylareopelle
    kaylareopelle committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    18a45d1 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Merge branch 'main' into logger-instrumentation

    @kaylareopelle
    kaylareopelle authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    09778b7 View commit details
    Browse the repository at this point in the history

  2. style: Add language to code fence

    @kaylareopelle
    kaylareopelle committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    d00bc1d View commit details
    Browse the repository at this point in the history

  3. Update instrumentation/logger/lib/opentelemetry/instrumentation.rb

    @kaylareopelle
    kaylareopelle authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    d129337 View commit details
    Browse the repository at this point in the history

  4. docs: add some config info

    @kaylareopelle
    kaylareopelle committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    97b42de View commit details
    Browse the repository at this point in the history

  5. feat: Remove config options

    @kaylareopelle
    kaylareopelle committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    6276944 View commit details
    Browse the repository at this point in the history

  6. chore: Add TODO for version number update

    @kaylareopelle
    kaylareopelle committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    ef88293 View commit details
    Browse the repository at this point in the history

  7. feat: Update example and readme

    @kaylareopelle
    kaylareopelle committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    00c8687 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'logger-instrumentation' of github.com:kaylareopelle/ope… 

    …ntelemetry-ruby-contrib into logger-instrumentation
    @kaylareopelle
    kaylareopelle committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    96a4a1b View commit details
    Browse the repository at this point in the history

  9. test: remove appraisals for eol'd rails versions

    @kaylareopelle
    kaylareopelle committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    7f8dce1 View commit details
    Browse the repository at this point in the history

  10. feat: Support ActiveSupport::BroadcastLogger 

    Rails 7.1+ uses ActiveSupport::BroadcastLogger. This needs to protect
against emitting duplicate logs in a different way than
ActiveSupport::Logger.broadcast.

Emits the log record for the first logger in the broadcast,
skip the others. Reset everything at the end of the method call.
    @kaylareopelle
    kaylareopelle committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    e5cc573 View commit details
    Browse the repository at this point in the history

  11. test: Remove config option tests

    @kaylareopelle
    kaylareopelle committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    ea3351e View commit details
    Browse the repository at this point in the history