feat: remove tracestate, add lineage support to X-Ray propagator #1380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving this PR as a draft until Lambda has confirmed they are ready for this change across all OTel SDKs. Reviews are welcome in the meantime.
All of OpenTelemetry language SDKs are moving towards support for the Lambda Lineage attribute in the X-Ray trace header via W3C Baggage. See this PR for the equivalent Java solution. This PR updates X-Ray propagator to pass lineage into baggage and inject it into outgoing X-Ray trace header.
The X-Ray propagator in other languages uses a delimiter-based scanning approach to extracting incoming X-Ray trace headers (see Java), whereas the Ruby uses regex matching. I updated the regex string to not only support the Lineage key, but also allow the keys to appear in any order as the other algorithms permit.
In addition, extraneous attributes in the X-Ray trace header are dropped instead of added to the span context's tracestate to match how the trace header is processed in the other language SDKs.