Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Update que Appraisals #1256

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

test: Update que Appraisals #1256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
29c0567
test: Update que Appraisals
kaylareopelle Nov 19, 2024
3b9224f
test: Appraise specific Active Record versions
kaylareopelle Nov 20, 2024
df52944
test: Add Ruby version constraint to activerecord
kaylareopelle Nov 21, 2024
0d5dcd6
test: remove extra end
kaylareopelle Nov 21, 2024
0595e72
style: Rubocop indentation
kaylareopelle Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion instrumentation/que/Appraisals
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,19 @@

appraise 'que-1.x' do
gem 'que', '~> 1.4'
gem 'activerecord', '~> 7.1.0'
end

appraise 'que-2.x' do
gem 'que', '~> 2.3'
gem 'que', '~> 2.4'
if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3.1.0')
gem 'activerecord', '~> 7.2.0'
else
gem 'activerecord'
end
Comment on lines +14 to +18
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this, we'd skip testing on Rails 7.2 and jump straight to Rails 8.0. Que made a change to support Rails 7.2 in 2.4.1, but our instrumentation didn't need to change.

Since these tests are for our instrumentation and not necessarily for activerecord compatibility with que, I'm not sure we need the condition. Thoughts?

end

appraise 'que-latest' do
gem 'que'
gem 'activerecord'
end
1 change: 0 additions & 1 deletion instrumentation/que/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ source 'https://rubygems.org'
gemspec

group :test do
gem 'activerecord', '< 7.2.0', '> 6.1.0'
gem 'pg'
gem 'opentelemetry-helpers-sql-obfuscation', path: '../../helpers/sql-obfuscation'
gem 'opentelemetry-instrumentation-base', path: '../base'
Expand Down
Loading