Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use AS::N subscriber for serialize events #1075

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Commits on Jul 19, 2024

  1. fix: use AS::N subscriber for serialize events

    The details for Context management (i.e. setting current span) are
    already handled by the OTel ActiveSupport instrumentation. Reuse
    the notifications subscriber here for ActiveModel serialization events.
    
    Reworked the example app into two: one Rails which works with the usual
    SDK configuration and one standalone (no Rails) to demonstrate that the
    subscription needs to be made after the SDK configuration is complete.
    If the subscription is created during instrumentation install, the
    subscription's tracer will be a NO-OP API tracer and won't produce
    spans.
    robbkidd committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    13f2b7f View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Configuration menu
    Copy the full SHA
    5644ee5 View commit details
    Browse the repository at this point in the history