Make auto instrumentation use the same dependency resolver as manual instrumentation does #3202
+142
−140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjduffner
commented
Jan 22, 2025
opentelemetry-instrumentation/src/opentelemetry/instrumentation/instrumentor.py
Outdated
Show resolved
Hide resolved
rjduffner
force-pushed
the
rjduffner-autoinstrumentation-2
branch
3 times, most recently
from
9cf2a02 to
49762d1
Compare
rjduffner
changed the title
rjduffner
force-pushed
the
rjduffner-autoinstrumentation-2
branch
2 times, most recently
from
65d7192 to
00362cf
Compare
…instrumentation does
rjduffner
force-pushed
the
rjduffner-autoinstrumentation-2
branch
from
00362cf to
149f84f
Compare
|
@xrmx, Here is an option for making the auto instrumentation use the same dependency checker as the manual instrumentation. There are a few rough edges but I think ironing those out gets us down a path of a major rewrite pretty quickly so maybe this little PR could work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order for the auto instrumentation to use the same dependency checker as the instrumentation itself, I introduce an exception that allows for an early exit from instrument function through the distro and back to the _load.
Fixes #3201
Type of change
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.