Fix psycopg2 instrument issue #2795
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qiu, David <[email protected]>
lzchen
reviewed
Aug 13, 2024
...pentelemetry-instrumentation-psycopg2/src/opentelemetry/instrumentation/psycopg2/__init__.py
Show resolved
Hide resolved
Signed-off-by: Qiu, David <[email protected]>
Signed-off-by: Qiu, David <[email protected]>
Signed-off-by: Qiu, David <[email protected]>
xrmx
reviewed
Aug 31, 2024
|
Thanks for your suggestion, I will add a test case for it. |
|
xrmx
reviewed
Sep 5, 2024
instrumentation/opentelemetry-instrumentation-psycopg2/tests/test_psycopg2_integration.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Qiu, David <[email protected]>
Signed-off-by: Qiu, David <[email protected]>
lzchen
reviewed
Oct 28, 2024
| connection._is_instrumented_by_opentelemetry = True | ||
| else: | ||
| def instrument_connection(self, connection, tracer_provider=None): | ||
| if isinstance(connection, ObjectProxy): |
There was a problem hiding this comment.
I'm still not sure this solves the original issue (we still don't know WHY the error is being generated when we are trying to access _is_instrumented_by_opentelemetry field but this current change is fine as a short-term solution. Please add a TODO or follow-up issue to investigate.
lzchen
approved these changes
Oct 28, 2024
|
Please allow for maintainer edits so we can rebase for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently there is issue with psycopg2, the instrumentation can not work as expected. Update the codes based on mysql and sqlite3 to resolve the issue. Will check the two properties _otel_orig_cursor_factory and _is_instrumented_by_opentelemetry in subsequent issue later.
Fix one issue in unit test, assign instrumented connection to cnx.
Fixes #2522
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested with below command to run unit test
tox -e py310-test-opentelemetry-instrumentation-psycopg2
Tested traces with local environment and the traces are displayed without error.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.