-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SELinux Systems. #340
base: main
Are you sure you want to change the base?
Conversation
hdost
commented
Oct 20, 2021
- Gave the false trail that the file does not exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a way to verify the change. If anyone is able please do.
@tigrannajaryan Documentation on SELinux binding in docker https://docs.docker.com/storage/bind-mounts/#configure-the-selinux-label |
@open-telemetry/specs-approvers can anyone review/verify this PR? If no-one knows how I am going to close it as "stale". |
well that's unfortunate 😢 |
a31564a
to
f389979
Compare
@tigrannajaryan is the other PR proof enough for you? |
Please note that I used |
I am not sure in this context it needs to be shared but I can also make that change. |
* Gave the false trail that the file does not exist.
f389979
to
4cd5d5b
Compare
@marcalff @ThomsonTan can you please review this PR? If we get both your approvals we should be able to move forward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that code generation fails without the fix for SELINUX systems.
[malff@malff-desktop opentelemetry-proto]$ make
rm -rf ./gen/cpp
mkdir -p ./gen/cpp
docker run --rm -u 1000 -v/data/malff/CODE/MY_GITHUB/opentelemetry-proto:/data/malff/CODE/MY_GITHUB/opentelemetry-proto -w/data/malff/CODE/MY_GITHUB/opentelemetry-proto otel/build-protobuf:0.9.0 --proto_path=/data/malff/CODE/MY_GITHUB/opentelemetry-proto --cpp_out=./gen/cpp opentelemetry/proto/resource/v1/resource.proto
Emulate Docker CLI using podman. Create /etc/containers/nodocker to quiet msg.
opentelemetry/proto/resource/v1/resource.proto: File does not reside within any path specified using --proto_path (or -I). You must specify a --proto_path which encompasses this file. Note that the proto_path must be an exact prefix of the .proto file names -- protoc is too dumb to figure out when two paths (e.g. absolute and relative) are equivalent (it's harder than you think).
make: *** [Makefile:56: gen-cpp] Error 1
Verified that code generation works with the fix for SELINUX systems.
Approved, thanks for the fix.
@open-telemetry/specs-approvers please take a look. I think this is good to merge and verified to work by @marcalff. |