Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Contributing Guide #5479

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Conversation

loganrosen
Copy link
Contributor

Which problem is this PR solving?

The Contributing Guide refers to enforcement of Conventional Commits via commitlint and husky, which is no logner the case as of #2898.

Short description of the changes

Updating the Contributing Guide to reflect how Conventional Commits are now a recommendation that is not enforced.

How Has This Been Tested?

Rendered the Markdown and ensured that it looks correct.

Updating the documentation about Conventional Commits in the Contributing Guide.
@loganrosen loganrosen requested a review from a team as a code owner February 15, 2025 05:10
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.92%. Comparing base (c27fbc6) to head (57a4843).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5479   +/-   ##
=======================================
  Coverage   94.92%   94.92%           
=======================================
  Files         308      308           
  Lines        7994     7994           
  Branches     1687     1687           
=======================================
  Hits         7588     7588           
  Misses        406      406           

@pichlermarc pichlermarc added this pull request to the merge queue Feb 17, 2025
Merged via the queue into open-telemetry:main with commit e9d3c71 Feb 17, 2025
18 checks passed
@opentelemetrybot
Copy link
Contributor

Thank you for your contribution @loganrosen! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants