Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exporter-logs/trace-otlp-grpc): fix error for missing dependency otlp-exporter-base (backport) #5470

Conversation

JamieDanielson
Copy link
Member

Which problem is this PR solving?

Backport #5412 to v1.x branch

#5031 was a large refactor for OTLP exporters, and a dependency that was previously listed as a dev dependency is now required as a production dependency. Upgrading to experimental/v0.56.0 caused an error in Yarn PnP:

2025-01-09T01:35:53.432Z   220 U Error: @opentelemetry/exporter-logs-otlp-grpc tried to access @opentelemetry/otlp-exporter-base, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

Short description of the changes

  • move @opentelemetry/otlp-exporter-base to be production dependency

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

@JamieDanielson JamieDanielson requested a review from a team as a code owner February 13, 2025 16:09
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v1.x@ae2d3a1). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             v1.x    #5470   +/-   ##
=======================================
  Coverage        ?   94.66%           
=======================================
  Files           ?      322           
  Lines           ?     8060           
  Branches        ?     1633           
=======================================
  Hits            ?     7630           
  Misses          ?      430           
  Partials        ?        0           

@pichlermarc pichlermarc merged commit 28b7908 into open-telemetry:v1.x Feb 13, 2025
20 checks passed
@JamieDanielson JamieDanielson deleted the jamie.backport-grpc-exporter-1.x branch February 13, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants