feat(sdk-trace-base)!: do not read environment variables from window #5455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5455 +/- ##
==========================================
+ Coverage 94.94% 94.97% +0.02%
==========================================
Files 309 309
Lines 8016 8016
Branches 1699 1704 +5
==========================================
+ Hits 7611 7613 +2
+ Misses 405 403 -2
|
pichlermarc
force-pushed
the
feat/migrate-from-getenv-sdk-trace-base
branch
from
f80a79e to
245c6f8
Compare
pichlermarc
added
target:next-major-release
4 tasks
trentm
approved these changes
Feb 13, 2025
| }); | ||
| default: | ||
| diag.error( | ||
| `OTEL_TRACES_SAMPLER value "${environment.OTEL_TRACES_SAMPLER} invalid, defaulting to ${FALLBACK_OTEL_TRACES_SAMPLER}".` | ||
| `OTEL_TRACES_SAMPLER value "${sampler} invalid, defaulting to ${FALLBACK_OTEL_TRACES_SAMPLER}".` | ||
| ); | ||
| return new AlwaysOnSampler(); |
There was a problem hiding this comment.
Unrelated to this PR: it strikes me as wrong that ParentBasedAlwaysOn is the default if not specified, but a different value (AlwaysOnSampler) is the fallback if the given value is unknown.
I opened #5476 for this.
There was a problem hiding this comment.
that is indeed wrong - thank you for opening the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Migrates from
getEnv()to using the newget*FromEnv()methods added in #5443. Also inlines the defaults. This drops"env var configuration" (via
window.OTEL_*) in browser environments. As such I had to move some tests to different places to ensure they only run in the correct context.This breaking change now will enable us to split the env var config code completely in a non-breaking feature release later.
Refs #5217
Type of change
How Has This Been Tested?