-
Notifications
You must be signed in to change notification settings - Fork 846
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(core): add stringToLogLevel utility
- Loading branch information
1 parent
cf445a5
commit 66d4704
Showing
5 changed files
with
108 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
/* | ||
* Copyright The OpenTelemetry Authors | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
import { diag, DiagLogLevel } from '@opentelemetry/api'; | ||
import { inspect } from 'util'; | ||
|
||
const logLevelMap: { [key: string]: DiagLogLevel } = { | ||
ALL: DiagLogLevel.ALL, | ||
VERBOSE: DiagLogLevel.VERBOSE, | ||
DEBUG: DiagLogLevel.DEBUG, | ||
INFO: DiagLogLevel.INFO, | ||
WARN: DiagLogLevel.WARN, | ||
ERROR: DiagLogLevel.ERROR, | ||
NONE: DiagLogLevel.NONE, | ||
}; | ||
|
||
/** | ||
* Convert a string to a {@link DiagLogLevel}, defaults to {@link DiagLogLevel} if the log level does not exist or undefined if the input is undefined. | ||
* @param value | ||
*/ | ||
export function stringToLogLevel( | ||
value: string | undefined | ||
): DiagLogLevel | undefined { | ||
if (value == null) { | ||
// don't fall back to default - no value set has different semantics for ús than an incorrect value (do not set vs. fall back to default) | ||
return undefined; | ||
} | ||
|
||
const resolvedLogLevel = logLevelMap[value.toUpperCase()]; | ||
|
||
if (resolvedLogLevel == null) { | ||
diag.warn( | ||
`Unknown log level ${inspect(value)}, expected one of ${inspect(Object.keys(logLevelMap))}, using default` | ||
); | ||
return DiagLogLevel.INFO; | ||
} | ||
|
||
return resolvedLogLevel; | ||
} |
54 changes: 54 additions & 0 deletions
54
packages/opentelemetry-core/test/common/utils/configuration.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
/* | ||
* Copyright The OpenTelemetry Authors | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
import { stringToLogLevel } from '../../../src'; | ||
import * as assert from 'assert'; | ||
import * as sinon from 'sinon'; | ||
import { diag, DiagLogLevel } from '@opentelemetry/api'; | ||
|
||
describe('stringToLogLevel', function () { | ||
afterEach(function () { | ||
sinon.restore(); | ||
}); | ||
|
||
it('should map valid string to log level', function () { | ||
assert.strictEqual(stringToLogLevel('ALL'), DiagLogLevel.ALL); | ||
assert.strictEqual(stringToLogLevel('VERBOSE'), DiagLogLevel.VERBOSE); | ||
assert.strictEqual(stringToLogLevel('DEBUG'), DiagLogLevel.DEBUG); | ||
assert.strictEqual(stringToLogLevel('INFO'), DiagLogLevel.INFO); | ||
assert.strictEqual(stringToLogLevel('WARN'), DiagLogLevel.WARN); | ||
assert.strictEqual(stringToLogLevel('ERROR'), DiagLogLevel.ERROR); | ||
assert.strictEqual(stringToLogLevel('NONE'), DiagLogLevel.NONE); | ||
}); | ||
|
||
it('should ignore casing when resolving', function () { | ||
assert.strictEqual(stringToLogLevel('error'), DiagLogLevel.ERROR); | ||
assert.strictEqual(stringToLogLevel('eRRoR'), DiagLogLevel.ERROR); | ||
}); | ||
|
||
it('should return undefined on undefined input', function () { | ||
assert.strictEqual(stringToLogLevel(undefined), undefined); | ||
}); | ||
|
||
it('should return undefined on null input', function () { | ||
assert.strictEqual(stringToLogLevel(undefined), undefined); | ||
}); | ||
|
||
it('should fall back to INFO and warn on input that cannot be mapped', function () { | ||
const warnStub = sinon.stub(diag, 'warn'); | ||
assert.strictEqual(stringToLogLevel('does not exist'), DiagLogLevel.INFO); | ||
sinon.assert.calledOnceWithMatch(warnStub, 'Unknown'); | ||
}); | ||
}); |