Add experimental updateTracerConfigurations for dynamically updateable on/off instrumentation #6899
+33
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables dynamic config - it's all that is needed at the experimental level. For the complete solution it would be a
TracerProvider.updateTracerConfigurations()
interface method addition.A usage example is https://github.com/elastic/elastic-otel-java/blob/main/custom/src/main/java/co/elastic/otel/config/DynamicInstrumentation.java
Essentially, the configuration is set with an updatable ScopeConfigurator (see below fragment), then that can be updated at any time with eg
GlobalOpenTelemetry.getTracerProvider().updateTracerConfigurations()
I haven't added implementations for
DefaultTracerProvider
andExtendedDefaultTracerProvider
nor tests, because I feel this is fine for the experimental stage, but those could be added easily