Updated Camel rules adding route.started rooute.added and thread pool… #12763
+74
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s' pool.core_size
luigidemasi
force-pushed
the
camel-update
branch
from
da3f2f0
to
9ce2d56
Compare
PeterF778
reviewed
Nov 22, 2024
| StartedRoutes: | ||
| metric: route.started | ||
| type: updowncounter | ||
| unit: "{routes}" |
There was a problem hiding this comment.
The semantic conventions for metric units recommend using singular form, so {route} rather than {routes}.
PeterF778
reviewed
Nov 22, 2024
| @@ -246,6 +260,11 @@ rules: | |||
| type: updowncounter | |||
| unit: "{threads}" | |||
There was a problem hiding this comment.
Should be {thread}, according to the semantic conventions.
PeterF778
reviewed
Nov 22, 2024
| - bean: org.apache.camel:context=*,type=context,name=* | ||
| prefix: camel.context. | ||
| metricAttribute: | ||
| context: param(context) | ||
| camelVersion: beanattr(CamelVersion) | ||
| packageScanClassResolver: beanattr(PackageScanClassResolver) |
There was a problem hiding this comment.
The semantic conventions for metric attributes suggest using underscores to separate individual words, so these apparently should rather be camel_version and package_scan_class_resolver. But, given that you merely copy the MBean attributes here, I'm not sure what is more user-friendly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s' pool.core_size