Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SDK span concurrent safe #1300

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Make SDK span concurrent safe #1300

merged 2 commits into from
Nov 19, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Nov 18, 2024 •
edited
Loading

Part of #1297

Update the span implementation to ensure concurrent safe methods. Include a test to verify concurrent safety.

@MrAlias MrAlias added this to the v0.18.0-alpha milestone Nov 18, 2024
@MrAlias MrAlias marked this pull request as ready for review November 18, 2024 21:38
@MrAlias MrAlias requested a review from a team as a code owner November 18, 2024 21:38
@MrAlias MrAlias mentioned this pull request Nov 19, 2024
Closed
11 tasks
damemi
damemi reviewed Nov 19, 2024
View reviewed changes
sdk/trace.go Show resolved Hide resolved
@MrAlias MrAlias merged commit c8ccb8b into open-telemetry:main Nov 19, 2024
27 checks passed
@MrAlias MrAlias deleted the sdk-span-concurrency branch November 19, 2024 20:49
@MrAlias MrAlias mentioned this pull request Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonFed RonFed RonFed approved these changes

@damemi damemi damemi approved these changes

Assignees
No one assigned
Labels
Skip Changelog
Projects
Go Auto Instrumentation: Beta
Status: Done
Milestone
v0.18.0-alpha
Development

Successfully merging this pull request may close these issues.
3 participants
@MrAlias @damemi @RonFed