Test SDK TracerProvider #1298
Merged
Test SDK TracerProvider #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MrAlias
commented
Nov 18, 2024
MrAlias
commented
- Move the tracerProvider type and related functionality to its own file to help discoverability.
- Use a singleton instance of the tracerProvider for tracerProviderInstance instead of having a new value created each call to TracerProvider.
- Test the singleton nature of TracerProvider.
- Test the concurrent safe behavior of the provided TracerProvider (part of SDK needs to be concurrent safe #1297).
Move the tracerProvider type and related functionality to its own file to help discoverability. Use a singleton instance of the tracerProvider for tracerProviderInstance instead of having a new value created each call to TracerProvider. Test the singleton nature of TracerProvider. Test the concurrent safe behavior of the provided TracerProvider (part of open-telemetry#1297).
MrAlias
force-pushed
the
sdk-tracer-provider
branch
from
f6b8ba1
to
507e39c
Compare
11 tasks
|
Which part here addresses concurrency? If I understood this correctly, the old code also used a singleton? |
Correct. The old code is already concurrent safe. This just adds a test to ensure that it remains that way. The old code uses a default value as the file scope tracer provider. Since Go will always copy-by-value, each value returned from |
RonFed
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.