Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Instrumentation.Run to Load and Run #1245

Merged
merged 16 commits into from
Nov 18, 2024
Merged

Split Instrumentation.Run to Load and Run #1245

merged 16 commits into from
Nov 18, 2024

Conversation

RonFed
Copy link
Contributor

@RonFed RonFed commented Nov 6, 2024 •
edited
Loading

Resolves #1240

  • Split Instrumentation.Run to 2 parts - Load and Run.
  • Remove loadedIndicator.
  • Add Manager.Stop which should be called if Instrumentation.Close is called in between Load and Run.
  • Improve state handling inside the manager and protect it with a mutex.

@RonFed RonFed marked this pull request as ready for review November 6, 2024 12:48
@RonFed RonFed requested a review from a team as a code owner November 6, 2024 12:48
@MrAlias MrAlias added this to the v0.18.0-alpha milestone Nov 7, 2024
MrAlias
MrAlias reviewed Nov 7, 2024
View reviewed changes
instrumentation.go Show resolved Hide resolved
internal/pkg/instrumentation/manager.go Show resolved Hide resolved
internal/pkg/instrumentation/manager.go Outdated Show resolved Hide resolved
@RonFed RonFed requested a review from MrAlias November 17, 2024 16:38
MrAlias
MrAlias reviewed Nov 17, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
internal/pkg/instrumentation/bpffs/bpfsfs_other.go Outdated Show resolved Hide resolved
MrAlias
MrAlias approved these changes Nov 18, 2024
View reviewed changes
instrumentation.go Outdated Show resolved Hide resolved
@MrAlias MrAlias merged commit 5007dc3 into open-telemetry:main Nov 18, 2024
27 checks passed
@MrAlias MrAlias mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias approved these changes

@damemi damemi damemi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.18.0-alpha
Development

Successfully merging this pull request may close these issues.

Improve Instrumentation.Run API
3 participants
@RonFed @damemi @MrAlias