Don't include db.query if it is empty (#1246)

* Don't include db.query if it is empty * Add changelog entry
open-telemetry · Nov 6, 2024 · 2b22ff5 · 2b22ff5
1 parent 454a9ca
commit 2b22ff5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,10 @@ OpenTelemetry Go Automatic Instrumentation adheres to [Semantic Versioning](http
 
 ## [Unreleased]
 
+### Fixed
+
+- Don't include `db.query.text` attribute in `database/sql` if the query string is empty or not collected. ([#1246](https://github.com/open-telemetry/opentelemetry-go-instrumentation/pull/1246))
+
 ## [v0.17.0-alpha] - 2024-11-05
 
 ### Changed

diff --git a/internal/pkg/instrumentation/bpf/database/sql/probe.go b/internal/pkg/instrumentation/bpf/database/sql/probe.go
@@ -93,7 +93,9 @@ func processFn(e *event) ptrace.SpanSlice {
 	}
 
 	query := unix.ByteSliceToString(e.Query[:])
-	span.Attributes().PutStr(string(semconv.DBQueryTextKey), query)
+	if query != "" {
+		span.Attributes().PutStr(string(semconv.DBQueryTextKey), query)
+	}
 
 	return spans
 }