Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] add multi platform build support #1785

Merged

Conversation

puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Nov 21, 2024

Changes

Adds 4 new make targets to support building multiplatform images (arm64 & amd64): create-multiplatform-builder, removed-multiplatform-builders, build-multiplatform, and build-multiplatform-and-push.

Dockerfile for nearly all services were updated to correct for warnings emitted by buildx, and to add appropriate build logic for multiple platforms.

Merge Requirements

For new features contributions, please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

Makefile Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
@julianocosta89
Copy link
Member

Hey @puckpuck the build builds now, but when I run make start with those images, the currency service is unreachable.
I ran the PR with a pruned system.

Then, after building and the failures in the currency service, I've pruned again and built from main.
Everything worked fine.

Not sure if we need to specify anything else on the make start when the images are built with the buildx, but as of it is not, it is sadly not working :/

@puckpuck
Copy link
Contributor Author

@julianocosta89 The currency service had an issue in the Dockerfile. I pushed a fix for it.

I started from a clean and pruned system and did the following:

make create-multiplatform-builder
make build-muiltiplatform
make start

All services started as expected, and I verified the traces in Jaeger.

Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
Thanks for patience @puckpuck!

Left a minor suggestion, but it looks good to me 🚀

CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Juliano Costa <[email protected]>
@julianocosta89 julianocosta89 merged commit 8a86840 into open-telemetry:main Nov 24, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants