-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] add multi platform build support #1785
[chore] add multi platform build support #1785
Conversation
…o chore.multi-platform-builds
# Conflicts: # CHANGELOG.md # Makefile # docker-compose-tests.yml
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md # src/accountingservice/Dockerfile # src/cartservice/src/Dockerfile
Hey @puckpuck the build builds now, but when I run Then, after building and the failures in the currency service, I've pruned again and built from main. Not sure if we need to specify anything else on the |
@julianocosta89 The currency service had an issue in the Dockerfile. I pushed a fix for it. I started from a clean and pruned system and did the following:
All services started as expected, and I verified the traces in Jaeger. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Thanks for patience @puckpuck!
Left a minor suggestion, but it looks good to me 🚀
Co-authored-by: Juliano Costa <[email protected]>
Changes
Adds 4 new make targets to support building multiplatform images (arm64 & amd64):
create-multiplatform-builder
,removed-multiplatform-builders
,build-multiplatform
, andbuild-multiplatform-and-push
.Dockerfile for nearly all services were updated to correct for warnings emitted by buildx, and to add appropriate build logic for multiple platforms.
Merge Requirements
For new features contributions, please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.