feat: --output-path flag for pizza generate codeowners
#223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
udaypatel1
changed the title
udaypatel1
changed the title
--output-path flag for pizza generate codeowners
jpmcb
requested changes
Oct 14, 2024
|
Great work on this! Thanks for taking the initiative to pick this up!! 👏🏼👏🏼 👏🏼 |
udaypatel1
force-pushed
the
feat/generate-codeowners-output-dir-flag
branch
2 times, most recently
from
0b30d66
to
a5a097f
Compare
jpmcb
requested changes
Oct 15, 2024
udaypatel1
force-pushed
the
feat/generate-codeowners-output-dir-flag
branch
3 times, most recently
from
b8d8a54
to
154a2d7
Compare
|
Log from within the target repo + flag:
Log from outside of the target repo + flag:
Log from within the target repo + no flag:
Log from outside of the target repo + no flag:
Feel free to suggest any log changes that you may want, if any. |
jpmcb
approved these changes
Oct 16, 2024
nickytonline
approved these changes
Oct 16, 2024
udaypatel1
force-pushed
the
feat/generate-codeowners-output-dir-flag
branch
from
154a2d7
to
09ed80b
Compare
open-sauced bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
## [2.4.0-beta.1](v2.3.0...v2.4.0-beta.1) (2024-10-16) ### 🍕 Features * `--output-path` flag for `pizza generate codeowners` ([#223](#223)) ([1c5ce09](1c5ce09))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds logic to handle an optional output directory flag value to the
generate codeownerscommandMirrors the expected behavior of the same flag that exists for
generate configRelated Tickets & Documents
Resolves #222
I am not sure how to self-assign the ticket – if an admin could assign the Issue to me, that'd be wonderful :)
Mobile & Desktop Screenshots/Recordings
Steps to QA
pizza generate codeownerswith and without the-o/--output-pathflagpizza generate codeowners .pizza generate codeowners . -o /path/to/some/directory/pizza generate codeowners . -o /path/to/some/directory/ --owners-style-fileAll other functionalities should remain unchanged and BAU. The optional flag should just create or modify in a specified file path that is given.
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?
Please let me know if I'm missing anything or there are complications! Thank you! 😁