Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add back to top button #281

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Asin-Junior-Honore
Copy link
Contributor

@Asin-Junior-Honore Asin-Junior-Honore commented May 18, 2024

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Steps to QA

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

Funny GIF

Copy link

netlify bot commented May 18, 2024

Deploy Preview for opensauced-landing ready!

Name Link
🔨 Latest commit 4528d43
🔍 Latest deploy log https://app.netlify.com/sites/opensauced-landing/deploys/6649b596365f8a0008b8ff69
😎 Deploy Preview https://deploy-preview-281--opensauced-landing.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 92 (no change from production)
SEO: 83 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@bdougie
Copy link
Member

bdougie commented May 18, 2024

The button is on the wrong page. I'd expect to see it while reading a long article https://opensauced.pizza/blog/how-we-saved-thousands-of-dollars-deploying-low-cost-open-source-ai-technologies

@Asin-Junior-Honore
Copy link
Contributor Author

@bdougie, oh yeah, that's true. Sorry, I placed it on the main blog page (http://localhost:3001/blog). Should I put the button only on the specific blog post page (http://localhost:3001/blog/how-we-saved-thousands-of-dollars-deploying-low-cost-open-source-ai-technologies), or should I include it on both the main blog page and the specific blog post page?

@bdougie
Copy link
Member

bdougie commented May 18, 2024

Yes. Only on blog post page.

I'd expect to see it while reading a long article

@Asin-Junior-Honore
Copy link
Contributor Author

@bdougie all done sir 🙇

@bdougie
Copy link
Member

bdougie commented May 18, 2024

I won't be able to view this from anything but mobile for awhile, but placement of the button is not working. I'd suggest centering it.

I'd also suggest providing screen shots and a description to the PR.

image

Please read this blog post. https://dev.to/opensauced/the-secret-recipe-to-getting-your-pull-requests-reviewed-and-merged-faster-1fag

@Asin-Junior-Honore
Copy link
Contributor Author

Hey, @bdougie
I apologize for any confusion caused. Upon revisiting the code base, I discovered that the tailwind.config.js file had been modified with different screen size configurations. This was preventing the button from adjusting properly with the initial logic I used.

However, I have rectified the issue. Here is the corrected and well-placed "Back to Top" button for mobile screen sizes and larger ones:

large-screen

largescreen

mobile-screen

mobile-screen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants